Skip to content

Add remote function support#1239

Merged
seratch merged 3 commits intoslackapi:mainfrom
seratch:remote-functions
Nov 21, 2023
Merged

Add remote function support#1239
seratch merged 3 commits intoslackapi:mainfrom
seratch:remote-functions

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Nov 20, 2023

This pull request adds remote function support, which is still in beta, to this SDK.

References:

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-app-backend labels Nov 20, 2023
@seratch seratch added this to the 1.x milestone Nov 20, 2023
@seratch seratch self-assigned this Nov 20, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (7942a3f) 74.18% compared to head (d51f7a8) 73.92%.

❗ Current head d51f7a8 differs from pull request most recent head aa9c542. Consider uploading reports for the commit aa9c542 to get more accurate results

Files Patch % Lines
...on/GsonFunctionExecutedEventInputValueFactory.java 17.64% 27 Missing and 1 partial ⚠️
...java/com/slack/api/methods/RequestFormBuilder.java 0.00% 8 Missing ⚠️
bolt/src/main/java/com/slack/api/bolt/App.java 57.14% 2 Missing and 4 partials ⚠️
...slack/api/methods/impl/AsyncMethodsClientImpl.java 0.00% 4 Missing ⚠️
.../com/slack/api/methods/impl/MethodsClientImpl.java 0.00% 4 Missing ⚠️
...k/api/bolt/request/builtin/BlockActionRequest.java 40.00% 2 Missing and 1 partial ⚠️
...m/slack/api/model/event/FunctionExecutedEvent.java 25.00% 2 Missing and 1 partial ⚠️
...m/slack/api/bolt/request/builtin/EventRequest.java 60.00% 0 Missing and 2 partials ⚠️
.../main/java/com/slack/api/bolt/context/Context.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1239      +/-   ##
============================================
- Coverage     74.18%   73.92%   -0.27%     
- Complexity     4097     4109      +12     
============================================
  Files           441      443       +2     
  Lines         13018    13106      +88     
  Branches       1310     1329      +19     
============================================
+ Hits           9657     9688      +31     
- Misses         2593     2642      +49     
- Partials        768      776       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WilliamBergamin
WilliamBergamin approved these changes Nov 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 it seems to align nicely with the JS and python implementations as well

Comment thread ...c/main/java/com/slack/api/app_backend/interactive_components/payload/BlockActionPayload.java Outdated

@Data
public static class Interactivity {
private String interactivityPointer; // you can use this in the samy way with trigger_id
Copy link
Copy Markdown
Contributor

@WilliamBergamin WilliamBergamin Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great field to highlight 💯

@seratch seratch marked this pull request as ready for review November 21, 2023 08:24
@seratch seratch merged commit aa9c542 into slackapi:main Nov 21, 2023
@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Nov 21, 2023

Mistakenly i merged this PR into main branch, so did force revert (by changing the branch protection settings for the operation; then i got back the proper protection settings); i will come up with a new PR for this; sorry for the confusion here

@seratch seratch mentioned this pull request Nov 21, 2023
Merged
6 tasks
@seratch seratch deleted the remote-functions branch May 11, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

@misscoded misscoded Awaiting requested review from misscoded

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-app-backend

Projects

None yet

Milestone

1.x

Development

Successfully merging this pull request may close these issues.

2 participants

@seratch @WilliamBergamin